Repository navigation
[skip ci] Apply canonical formatting and repair observed lint findings - #140
Merged
Merged
Conversation
This was referenced Nov 13, 2026
szmyty
changed the base branch from
codex/137-03-lock-metadata-20261113
to
main
November 14, 2026 01:39
szmyty
marked this pull request as ready for review
November 14, 2026 01:39
Pull Request Summary by devActivityMetricsAchievements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #137, checkpoint 4. Stacked after #139.
Applies the owning canonical formatter (Rustfmt/Cargo 1.85.0) across the declared Cargo targets, pins local Task/CI format commands, and preserves strict compiler lint lanes and the declared MSRV.
Repairs all 39 recorded moving-stable assert_is_empty findings using the historical Clippy typed assert_eq!/assert_ne! suggestions. Also corrects a pre-existing semicolon/comma syntax error in the delivery match arm that prevented the formatter from parsing the module.
Validation: the owning explicit-version cargo fmt --all -- --check commands exited 0; docs/work/137/04-format-lint.json records exact formatter identities and scope. No product type-check/Clippy/build/test, corpus/schema/native or hosted CI execution occurred. Formatting parses source but cannot establish Rust type/borrow correctness or a green Actions suite. No blanket lint allowances or continue-on-error changes.
The extensive diff reflects accumulated deferred formatting; review source layout separately from the named logical repairs (GitHub's whitespace-hidden view can help). No unrelated Identity workspace was formatted, and no fixture expectations are regenerated here. Full compiler/lint acceptance remains open under #137/#88. See docs/work/137/04-format-lint.md. [skip ci]